Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to find the correct download path without language suffixes at first run #660

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 8, 2022

No description provided.

@ghost ghost requested a review from micahflee as a code owner December 8, 2022 04:45
@AsciiWolf
Copy link
Collaborator

AsciiWolf commented Dec 8, 2022

Thanks, looks good! I will however wait for other reviews (preferably from @micahflee or other contributors) before adding this patch to the Tor Browser Launcher Flatpak. :-)

edit: After this gets properly reviewed, it should be merged ASAP (probably along with #642) and new version of torbrowser-launcher should be released.

@copiummax
Copy link

lol but isn't this now hardcoded to the new resource? you did the same thing and looks like it will break again when it changes.

unless i'm wrong, the first endpoint GET /torbrowser/update_3/release/Linux_x86_64-gcc3/x/en-US HTTP/1.1\r\n replied with a correct resource to fetch and i think you should parse that somehow, otherwise what's the use of querying it in the first place

@AsciiWolf
Copy link
Collaborator

Good point.

@copiummax
Copy link

copiummax commented Dec 8, 2022

would still work as a hotfix, and it's important because the thing is quite completely broken for any new users. So depends on what you decide to do, i might work on proper parsing later if no one does

@ghost
Copy link
Author

ghost commented Dec 8, 2022

That's right. I installed this package for the first time today, found an error and uploaded the corrected one, so this hotfix was my best. I think I won't fix this problem completely. I'll appreciate it if you can work on it

@hackerncoder
Copy link

hackerncoder commented Dec 9, 2022

lol but isn't this now hardcoded to the new resource? you did the same thing and looks like it will break again when it changes.

unless i'm wrong, the first endpoint GET /torbrowser/update_3/release/Linux_x86_64-gcc3/x/en-US HTTP/1.1\r\n replied with a correct resource to fetch and i think you should parse that somehow, otherwise what's the use of querying it in the first place

Nope, it doesn't. It gives a link to a mar file. And you can't just s/mar/tar.xz/, that 404s

Edit: Ok, you can pull the file name out of that, and then splice together a correct link at dist.tpo.

@ghost ghost mentioned this pull request Dec 9, 2022
Copy link

@mavasbel mavasbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hotfix works

@nullsurface
Copy link

Sweet, hopefully this can get approved quick.

Copy link

@soullessschizo soullessschizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@AsciiWolf
Copy link
Collaborator

There's also #660 that also removes the now unused code. Anyway, please see my comment. It will need a proper fix, preferably from (or approved by) @micahflee.

@micahflee
Copy link
Collaborator

Merged in #661

@micahflee micahflee closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants