-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to find the correct download path without language suffixes at first run #660
Conversation
Thanks, looks good! I will however wait for other reviews (preferably from @micahflee or other contributors) before adding this patch to the Tor Browser Launcher Flatpak. :-) edit: After this gets properly reviewed, it should be merged ASAP (probably along with #642) and new version of torbrowser-launcher should be released. |
lol but isn't this now hardcoded to the new resource? you did the same thing and looks like it will break again when it changes. unless i'm wrong, the first endpoint |
Good point. |
would still work as a hotfix, and it's important because the thing is quite completely broken for any new users. So depends on what you decide to do, i might work on proper parsing later if no one does |
That's right. I installed this package for the first time today, found an error and uploaded the corrected one, so this hotfix was my best. I think I won't fix this problem completely. I'll appreciate it if you can work on it |
Nope, it doesn't. It gives a link to a mar file. And you can't just s/mar/tar.xz/, that 404s Edit: Ok, you can pull the file name out of that, and then splice together a correct link at dist.tpo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hotfix works
Sweet, hopefully this can get approved quick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There's also #660 that also removes the now unused code. Anyway, please see my comment. It will need a proper fix, preferably from (or approved by) @micahflee. |
Merged in #661 |
No description provided.