Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code language-agnostic #661

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

Fil0sOFF
Copy link

@Fil0sOFF Fil0sOFF commented Dec 8, 2022

Language-selection code is not needed anymore, since TBB is a single multi-lingual package starting with v12.0

Fixes #659 .
Based on #660

since TBB provides now a single multi-lingual distribution
@AsciiWolf
Copy link
Collaborator

AsciiWolf commented Dec 8, 2022

It works, however it causes Tor Browser to be redownloaded and existing user profile purged. We should probably check whether the tor-browser-* directory already exists and if so, rename it to tor-browser.

edit: We should also somehow handle if multiple tor-browser-* directories (multiple languages) exist. Maybe use folder matching the currently active language (but we would have to restore discover_arch_lang() and its content for this), rename that folder to tor-browser and delete the other ones?

@ghost
Copy link

ghost commented Dec 9, 2022

im sorry but what was the location of the profiles? because i want to at least makke a local backup of my profile before this gets updated you know?

Copy link
Collaborator

@micahflee micahflee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm adding a commit to address @AsciiWolf's comment about renaming the existing tor-browser folder so you don't lose your profile.

@micahflee micahflee merged commit 006f498 into torproject:develop Dec 13, 2022
@TJL789987
Copy link

TJL789987 commented Dec 6, 2023

Hi I'm new to using linux but I'm having an issue. I see that this is the fix to the problem I'm having but simply copying the computer programming text and putting it into linux is not working. Would anyone mind telling me what I need to do?

@AsciiWolf
Copy link
Collaborator

AsciiWolf commented Dec 6, 2023

@TJL789987 You should have created a separate ticket for this. Anyway, take a look here. Clicking the "Install" button should hopefully work on your distribution.

@TJL789987
Copy link

TJL789987 commented Dec 7, 2023

Simply installing that will not work on my computer. This is the method I need and am using to try and install but the error is the same as everyone in this thread is having. Also thank you for helping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants