Remove use of deprecated platform.dist() (fixes #446) #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this PR be updated so @micahflee can merge it? |
platform.dist was deprecated a while ago and finally removed in Python 3.8. It was only used for a workaround for issue torproject#128 (and torproject#215) which is no longer necessary, so just remove the use altogether.
|
done |
|
I guess this is probably a better patch than #444 |
This was referenced Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform.dist was deprecated a while ago and finally removed in Python 3.8. It was only used for a workaround for issue #128 (and #215) which is no longer necessary, so just remove the use altogether.
This broke the build for me with the Gentoo overlay, which upgraded to Python 3.8 recently.