Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py for python3.8 compatibility #444

Closed
wants to merge 1 commit into from
Closed

Update setup.py for python3.8 compatibility #444

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2019

modified to enable getting distro for python3.8 while maintaining ability to use python3.7 and below
@0rion-HunterShield
Update setup.py
66781d2 
modified to enable getting distro for python3.8 while maintaining ability to use python3.7 and below
@ghost ghost requested a review from micahflee as a code owner November 16, 2019 10:09
@anthraxx
Copy link

anthraxx commented Mar 3, 2020

@micahflee ping
@kpcyrd
Copy link
Contributor

kpcyrd commented Oct 7, 2020

@micahflee can you have a look at this patch? It's still necessary to build the new torbrowser-launcher 3.3 with python >= 3.8.

@deskos-xp can you rebase your patch?

Thanks!
@yardenac
Copy link

yardenac commented Dec 2, 2020

This patch is still necessary, as setup.py is still using outdated syntax:

Traceback (most recent call last):
  File "setup.py", line 38, in <module>
    distro = platform.dist()[0]
AttributeError: module 'platform' has no attribute 'dist'

Rebased patch is at yardenac@5fe206b
@yardenac yardenac mentioned this pull request Dec 2, 2020
Closed
@yardenac
Copy link

yardenac commented Dec 2, 2020

On second thought, #470 does a better job solving this problem
@micahflee micahflee closed this Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants
@anthraxx @kpcyrd @yardenac @micahflee @0rion-HunterShield