Set language from LC_MESSAGES, not LC_CTYPE #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually it's just also debian bug: The fix is just to revert b828bdf |
|
Sorry, my previous comment was not correct. |
|
I uploaded 0.3.2-10 to debian, which included this patch. If you use debian, you can install it from backports. |
Calling `locale.getlocale()` checks LC_CTYPE, which is not meant for UI strings. Change the call to check LC_MESSAGES instead. Also call `locale.setlocale()` first to import the locale settings from the environment. This is not needed for LC_CTYPE due to https://bugs.python.org/issue6203 but is required for LC_MESSAGES. Closes torproject#361
creideiki
force-pushed
the
set-language-from-LC_MESSAGES
branch
from
cd8edcd
to
5206d46
Compare
|
Rebased the patch onto release 0.3.3. |
micahflee
approved these changes
Jun 18, 2021
|
Thanks! This will hopefully fix flathub/org.torproject.torbrowser-launcher#2. edit: It partially fixed it - Tor Browser is correctly translated now, however the Tor Browser Launcher itself is still in English. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
locale.getlocale()checks LC_CTYPE, which is not meant for UI strings. Change the call to check LC_MESSAGES instead.Also call
locale.setlocale()first to import the locale settings from the environment. This is not needed for LC_CTYPE due to https://bugs.python.org/issue6203 but is required for LC_MESSAGES.This Works For Me™, but I have only tested it on Gentoo Linux with the following locale settings:
Closes #361