Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Indexnode stuck at stopping progress cause by wrong lifetime control #34559

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #34557
pr: #34558

…trol

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 10, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jul 10, 2024
@sre-ci-robot sre-ci-robot merged commit a7190b0 into milvus-io:2.4 Jul 10, 2024
10 checks passed
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (60aab15) to head (1a0e6e8).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34559      +/-   ##
==========================================
- Coverage   84.41%   79.82%   -4.60%     
==========================================
  Files         786     1051     +265     
  Lines      112475   135835   +23360     
==========================================
+ Hits        94951   108426   +13475     
- Misses      13305    23197    +9892     
+ Partials     4219     4212       -7     
Files Coverage Δ
internal/indexnode/indexnode.go 79.77% <0.00%> (+1.24%) ⬆️

... and 294 files with indirect coverage changes

weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Jul 12, 2024
include pr: milvus-io#34019,milvus-io#34502,milvus-io#34559

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
czs007 pushed a commit that referenced this pull request Jul 13, 2024
include pr: #34019,#34502,#34559

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
3 participants