Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Indexnode stuck at stopping progress cause by wrong lifetime control #34558

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: Indexnode stuck at stopping progress cause by wrong lifetime control #34558

merged 1 commit into from
Jul 10, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #34557
@weiliu1031
fix: Indexnode stuck at stopping progress cause by wrong lifetime con…
b1578bc 
…trol

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 10, 2024
@weiliu1031 weiliu1031 mentioned this pull request Jul 10, 2024
Merged
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 10, 2024
@weiliu1031 weiliu1031 mentioned this pull request Jul 10, 2024
Merged
congqixia
congqixia approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
sre-ci-robot pushed a commit that referenced this pull request Jul 10, 2024
@weiliu1031
fix: Indexnode stuck at stopping progress cause by wrong lifetime con…
0bfa1a7 
…trol (#34560)

issue: #34557
pr: #34558

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@mergify mergify bot added the ci-passed label Jul 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.37%. Comparing base (3c70463) to head (b1578bc).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #34558       +/-   ##
===========================================
+ Coverage   71.48%   84.37%   +12.88%     
===========================================
  Files        1127      858      -269     
  Lines      139271   115156    -24115     
===========================================
- Hits        99556    97158     -2398     
+ Misses      35426    13702    -21724     
- Partials     4289     4296        +7
Files Coverage Δ
internal/indexnode/indexnode.go 78.08% <0.00%> (-0.45%) ⬇️

... and 307 files with indirect coverage changes
@sre-ci-robot sre-ci-robot merged commit ebc68d2 into milvus-io:master Jul 10, 2024
11 of 12 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 10, 2024
@weiliu1031
fix: Indexnode stuck at stopping progress cause by wrong lifetime con…
a7190b0 
…trol (#34559)

issue: #34557
pr: #34558

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
3 participants
@weiliu1031 @sre-ci-robot @congqixia