Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: skip orphan channel cp meta when checking cp lag #34556

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #34545
pr: #34555

Signed-off-by: jaime <yun.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 10, 2024
@jaime0815 jaime0815 added this to the 2.4.6 milestone Jul 10, 2024
@mergify mergify bot added the ci-passed label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.91%. Comparing base (f0d12aa) to head (d25edd2).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #34556       +/-   ##
===========================================
- Coverage   84.42%   69.91%   -14.52%     
===========================================
  Files         786     1051      +265     
  Lines      112476   135849    +23373     
===========================================
+ Hits        94959    94978       +19     
- Misses      13308    36666    +23358     
+ Partials     4209     4205        -4     
Files Coverage Δ
internal/datacoord/util.go 98.78% <100.00%> (+0.05%) ⬆️
pkg/util/funcutil/func.go 91.80% <100.00%> (+0.22%) ⬆️

... and 295 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaime0815, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 073a501 into milvus-io:2.4 Jul 11, 2024
11 of 12 checks passed
@jaime0815 jaime0815 deleted the skip-orphan-meta-24 branch July 11, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
3 participants