Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: skip orphan channel cp meta when checking cp lag #34555

Merged
merged 1 commit into from
Jul 11, 2024
Merged

enhance: skip orphan channel cp meta when checking cp lag #34555

merged 1 commit into from
Jul 11, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Jul 10, 2024 •
edited
Loading

issue: # #34545

Print warn log instead of check health fail if orphan channel cp meta is found in health check request.
@jaime0815
enhance: skip orphan channel cp meta when checking cp lag
4cbe00b 
Signed-off-by: jaime <yun.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 10, 2024
@jaime0815 jaime0815 mentioned this pull request Jul 10, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 10, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e
@mergify mergify bot added the ci-passed label Jul 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (3c70463) to head (4cbe00b).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34555      +/-   ##
==========================================
+ Coverage   71.48%   80.69%   +9.21%     
==========================================
  Files        1127     1127              
  Lines      139271   139340      +69     
==========================================
+ Hits        99556   112444   +12888     
+ Misses      35426    22613   -12813     
+ Partials     4289     4283       -6
Files Coverage Δ
internal/datacoord/util.go 98.78% <100.00%> (+0.05%) ⬆️
pkg/util/funcutil/func.go 91.80% <100.00%> (+0.22%) ⬆️

... and 226 files with indirect coverage changes
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaime0815, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sre-ci-robot sre-ci-robot merged commit c332f69 into milvus-io:master Jul 11, 2024
12 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 11, 2024
@jaime0815
enhance: skip orphan channel cp meta when checking cp lag (#34556)
073a501 
issue: #34545
pr: #34555

Signed-off-by: jaime <yun.zhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
3 participants
@jaime0815 @xiaofan-luan @sre-ci-robot