Refactor to decouple from relying directly on proto #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Nov 18, 2023
Comment on lines
+49
to
+55
| compression: Option<Compression>, | ||
| type_description: Arc<TypeDescription>, | ||
| number_of_rows: u64, | ||
| /// Statistics of columns across entire file | ||
| column_statistics: Vec<ColumnStatistics>, | ||
| stripes: Vec<StripeMetadata>, | ||
| user_custom_metadata: HashMap<String, Vec<u8>>, |
There was a problem hiding this comment.
Doesn't contain all fields yet, but can fill in more as needed (such as rowIndexStride)
Comment on lines
+56
to
+58
| // TODO: for now keeping this, but ideally won't want all stripe footers here | ||
| // since don't want to require parsing all stripe footers in file unless actually required | ||
| stripe_footers: Vec<StripeFooter>, |
There was a problem hiding this comment.
Hoping to move this out of this struct, as don't want to require parsing all stripe footers in file upfront (at least not in this metadata section)
Comment on lines
+106
to
+109
| // TODO: false count? | ||
| Some(TypeStatistics::Bucket { | ||
| true_count: stats.count[0], // TODO: safety check this | ||
| }) |
There was a problem hiding this comment.
ORC spec is kinda vague on details here, been referring to https://github.com/apache/orc/blob/e1c7e4d9150820fa64b151ad942bffdf81ef34d0/c%2B%2B/src/Statistics.cc#L197
Might need further investigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41
Start introducing some of our own structs/types to represent their protobuf counter part
Allows us to have more control, such as ensuring fields are actually present (since proto has them as Option usually)