Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor metadata into our own classes #41

Open
Jefffrey opened this issue Nov 14, 2023 · 0 comments
Open

Refactor metadata into our own classes #41

Jefffrey opened this issue Nov 14, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request high High priority

Comments

@Jefffrey
Copy link
Collaborator

Currently the file metadata:

pub struct FileMetadata {
pub postscript: PostScript,
pub footer: Footer,
pub metadata: Metadata,
pub stripe_footers: Vec<StripeFooter>,
}

And stripe metadata:

pub struct Stripe {
pub(crate) footer: Arc<StripeFooter>,
pub(crate) columns: Vec<Column>,
pub(crate) stripe_offset: usize,
pub(crate) info: StripeInformation,
/// <(ColumnId, Kind), Bytes>
pub(crate) stream_map: Arc<StreamMap>,
}

Rely directly on proto structs/types.

Will work on refactoring to add our own versions of these structs/types as a sort of decoupling layer, and to potentially have a nicer interface for what we need from the metadata.

@Jefffrey Jefffrey self-assigned this Nov 14, 2023
@Jefffrey Jefffrey added enhancement New feature or request high High priority labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high High priority
1 participant