Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#943] replace logback with log4j #945

Merged
merged 3 commits into from
Jun 24, 2023
Merged

[#943] replace logback with log4j #945

merged 3 commits into from
Jun 24, 2023

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Jun 21, 2023

fixes #943

logback was probably added for tests or out of ignorance of the existing log4j dependency.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bmarwell bmarwell marked this pull request as ready for review June 21, 2023 15:00
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to remove the logback.xml file in main resource and replace it by a log4j2 default config file

@bmarwell
Copy link
Contributor Author

We also need to remove the logback.xml file in main resource and replace it by a log4j2 default config file

Please check if the config works for you (by executing the app manually, for example). Thanks for pointing me to this oversight! 👍🏻

@bmarwell bmarwell requested a review from fpapon June 22, 2023 11:53
@bmarwell bmarwell added this to the 2.0 milestone Jun 24, 2023
@bmarwell bmarwell merged commit 1a572eb into main Jun 24, 2023
24 checks passed
@bmarwell bmarwell deleted the #943_remove_logback branch June 24, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants