Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logback #943

Closed
bmarwell opened this issue Jun 21, 2023 · 1 comment · Fixed by #945
Closed

Remove logback #943

bmarwell opened this issue Jun 21, 2023 · 1 comment · Fixed by #945
Assignees
@bmarwell
Labels
dependencies Pull requests that update a dependency file
Milestone
2.0

Comments

@bmarwell
Copy link
Contributor

Most modules use log4j2, so logback snuck in by accident. Replace logback with log4j2.
@bmarwell bmarwell added the dependencies Pull requests that update a dependency file label Jun 21, 2023
@bmarwell bmarwell added this to the 2.0 milestone Jun 21, 2023
@fpapon fpapon self-assigned this Jun 21, 2023
@fpapon
Copy link
Member

fpapon commented Jun 21, 2023

I'm already working on this one, the only place we are using logback is on the hasher tool unit test:

https://github.com/apache/shiro/blob/main/tools/hasher/src/test/java/org/apache/shiro/tools/hasher/HasherTest.java
bmarwell added a commit that referenced this issue Jun 21, 2023
@bmarwell
[#943] replace logback with log4j
3e3ed6b
@bmarwell bmarwell mentioned this issue Jun 21, 2023
Merged
9 tasks
bmarwell added a commit that referenced this issue Jun 21, 2023
@bmarwell
[#943] remove logback from hasher test
d44354c
@fpapon fpapon assigned bmarwell and unassigned fpapon Jun 21, 2023
bmarwell added a commit that referenced this issue Jun 22, 2023
@bmarwell
[#943] convert logback.xml to log4j2.xml
97a8156
bmarwell added a commit that referenced this issue Jun 24, 2023
@bmarwell
Merge pull request #945 from apache/#943_remove_logback
1a572eb 
[#943] replace logback with log4j
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
2 participants
@bmarwell @fpapon