[ISSUE #8365] add remoting client non-oneway updateConsumerOffset function #8368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianye1001
changed the title
drpmma
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8368 +/- ##
=============================================
+ Coverage 44.22% 44.29% +0.07%
- Complexity 10727 10752 +25
=============================================
Files 1274 1274
Lines 88939 88951 +12
Branches 11432 11433 +1
=============================================
+ Hits 39330 39403 +73
+ Misses 44636 44590 -46
+ Partials 4973 4958 -15 ☔ View full report in Codecov by Sentry. |
drpmma
requested changes
Jul 5, 2024
client/src/main/java/org/apache/rocketmq/client/impl/mqclient/MQClientAPIExt.java
Outdated
Show resolved
Hide resolved
qianye1001
force-pushed
the
Enhancement#8365
branch
from
181be30
to
77d6633
Compare
drpmma
reviewed
Jul 11, 2024
client/src/main/java/org/apache/rocketmq/client/impl/mqclient/MQClientAPIExt.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Enhancement #8365
Brief Description
add remoting client non-oneway updateConsumerOffset function
How Did You Test This Change?
add some new unit test