Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spec): Add schema types #5

Merged
merged 3 commits into from
Jul 8, 2024
Merged

feat(spec): Add schema types #5

merged 3 commits into from
Jul 8, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 6, 2024

This PR will add schema types. The parse for DataType is not implemented yet.
@Xuanwo
feat(paimon/spec): Add schema types
4e021ab 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo mentioned this pull request Jul 6, 2024
Open
8 tasks
@Xuanwo Xuanwo requested a review from JingsongLi July 6, 2024 03:37
@Xuanwo Xuanwo changed the title feat(paimon/spec): Add schema types Jul 6, 2024
JingsongLi
JingsongLi approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@JingsongLi
Copy link
Contributor

@Xuanwo Please resolve conflicts.
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 8, 2024

@Xuanwo Please resolve conflicts.

Will do
@Xuanwo
Merge remote-tracking branch 'origin/main' into add-spec
37b7ea1 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Remove src
e67e4bf 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 8, 2024

DONE, @JingsongLi PTAL, thanks!
@JingsongLi
Copy link
Contributor

+1
@JingsongLi JingsongLi merged commit 6777f09 into apache:main Jul 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Xuanwo @JingsongLi