Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explainer for "once" parameter in setReportEventDataForAutomaticBeacons #718

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Add explainer for "once" parameter in setReportEventDataForAutomaticBeacons #718

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
381e6cc
add onlyForNextAutomaticBeacon to explainer
blu25 Jul 13, 2023
8e0b35e
add manual clearing part
blu25 Jul 19, 2023
4f3ba5d
update variable name to reflect change in code review
blu25 Jul 20, 2023
d0fc15c
clarify behavior and reason for adding
blu25 Jul 27, 2023
92a921f
address review comments
blu25 Jul 31, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clarify behavior and reason for adding
  • Loading branch information
@blu25
blu25 committed Jul 27, 2023
commit d0fc15cfbc643c7505ff888e4cdbb708d6509c78
4 changes: 2 additions & 2 deletions Fenced_Frames_Ads_Reporting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,6 @@ window.fence.setReportEventDataForAutomaticBeacons({
});
```

`once` is optional, and, if empty, will default to false. If `once` is set to true, the automatic beacon will only be sent for the next `reserved.top_navigation` event. Beacons will not be sent for subsequent `reserved.top_navigation` events.

`setReportEventDataForAutomaticBeacons` can also be invoked in the click handler of an anchor tag, and will be sent on navigation:

```
Expand All @@ -207,6 +205,8 @@ function addBeaconData(element) {

The beacon data will be in place by the time that the navigation starts. When the navigation commits, the automatic beacon will be sent out with event data set to "link1 was clicked.".

`once` is optional, and, if empty, will default to false. If `once` is set to true, the automatic beacon will only be sent for the next `reserved.top_navigation` event. Beacons will not be sent for subsequent `reserved.top_navigation` events until `setReportEventDataForAutomaticBeacons` is invoked again. When used with a click handler, this can be used to send beacons only for specific top-level navigations, rather than for every top-level navigation.
JensenPaul marked this conversation as resolved.
Show resolved Hide resolved
blu25 marked this conversation as resolved.
Show resolved Hide resolved

# Support for Ad Components
## Goal
When a rendered ad is composed of [multiple pieces](https://github.com/WICG/turtledove/blob/main/FLEDGE.md#34-ads-composed-of-multiple-pieces), it is useful to detect user clicks that happened on ad components.
Expand Down