Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explainer for "once" parameter in setReportEventDataForAutomaticBeacons #718

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Add explainer for "once" parameter in setReportEventDataForAutomaticBeacons #718

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
381e6cc
add onlyForNextAutomaticBeacon to explainer
blu25 Jul 13, 2023
8e0b35e
add manual clearing part
blu25 Jul 19, 2023
4f3ba5d
update variable name to reflect change in code review
blu25 Jul 20, 2023
d0fc15c
clarify behavior and reason for adding
blu25 Jul 27, 2023
92a921f
address review comments
blu25 Jul 31, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update variable name to reflect change in code review
  • Loading branch information
@blu25
blu25 committed Jul 20, 2023
commit 4f3ba5d44154c636c347f5f9f9228e1b0b3dfcb5
4 changes: 2 additions & 2 deletions Fenced_Frames_Ads_Reporting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ window.fence.setReportEventDataForAutomaticBeacons({
'eventType': 'reserved.top_navigation',
'eventData': 'an example string',
'destination': ['seller', 'buyer'],
'onlyForNextAutomaticBeacon': false
'once': false
blu25 marked this conversation as resolved.
Show resolved Hide resolved
});
```

Expand All @@ -186,7 +186,7 @@ window.fence.setReportEventDataForAutomaticBeacons({
});
```

`onlyForNextAutomaticBeacon` is optional, and, if empty, will default to false. If `onlyForNextAutomaticBeacon` is set to true, the automatic beacon will only be sent for the next `reserved.top_navigation` event. Beacons will not be sent for subsequent `reserved.top_navigation` events.
`once` is optional, and, if empty, will default to false. If `once` is set to true, the automatic beacon will only be sent for the next `reserved.top_navigation` event. Beacons will not be sent for subsequent `reserved.top_navigation` events.
blu25 marked this conversation as resolved.
Show resolved Hide resolved

`setReportEventDataForAutomaticBeacons` can also be invoked in the click handler of an anchor tag, and will be sent on navigation:

Expand Down