Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FencedFrameConfig IDL objects serializable #111

Merged
merged 6 commits into from
Aug 26, 2023
Merged

Make FencedFrameConfig IDL objects serializable #111

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad1187b
add serialization steps
blu25 Aug 7, 2023
22d2988
formatting
blu25 Aug 7, 2023
52b86ae
Merge branch 'master' into liam-serializable-config
blu25 Aug 17, 2023
f9bebc0
make config serializable
blu25 Aug 18, 2023
0f04118
address review comments
blu25 Aug 22, 2023
4cfb07d
remove reference to variable name
blu25 Aug 24, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting
  • Loading branch information
@blu25
blu25 committed Aug 7, 2023
commit 22d2988eb45818bff23ee570e3a34d41fe93de21
7 changes: 3 additions & 4 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,8 +1190,8 @@ Each {{FencedFrameConfig}} has:
</div>

<div algorithm="FencedFrameConfig serializer">
{{FencedFrameConfig}} objects are [=serializable objects=]. Their
[=serialization steps=], given |value|, |serialized|, and |forStorage| are:
{{FencedFrameConfig}} objects are [=serializable objects=]. Their [=serialization steps=], given
|value|, |serialized|, and |forStorage| are:

1. If |forStorage| is true, then throw a {{DataCloneError}} {{DOMException}}.

Expand All @@ -1202,8 +1202,7 @@ Each {{FencedFrameConfig}} has:

<div algorithm="FencedFrameConfig deserializer">
Their
[=deserialization steps=], given |serialized|, |value|, and <var ignore>
targetRealm</var> are:
[=deserialization steps=], given |serialized|, |value|, and <var ignore> targetRealm</var> are:

1. Initialize |value|'s [=fencedframeconfig/urn=] attribute to |serialized|.`[[Urn]]`.
blu25 marked this conversation as resolved.
Show resolved Hide resolved

Expand Down