Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FencedFrameConfig IDL objects serializable #111

Merged
merged 6 commits into from
Aug 26, 2023
Merged

Make FencedFrameConfig IDL objects serializable #111

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad1187b
add serialization steps
blu25 Aug 7, 2023
22d2988
formatting
blu25 Aug 7, 2023
52b86ae
Merge branch 'master' into liam-serializable-config
blu25 Aug 17, 2023
f9bebc0
make config serializable
blu25 Aug 18, 2023
0f04118
address review comments
blu25 Aug 22, 2023
4cfb07d
remove reference to variable name
blu25 Aug 24, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review comments
  • Loading branch information
@blu25
blu25 committed Aug 22, 2023
commit 0f041182fe1cdd3ac7e9f728eed7b45940430fae
72 changes: 35 additions & 37 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,9 +526,10 @@ returned to the web platform in a constant amount of time, before any computatio
depends on cross-site data. Because the privacy of this depends on the web platform not being able
to discern when a pending config is finalized, it is important that all visibilities and values of
transparent fields do not change from the pending config to the finalized config, given that they
can be inspected through {{FencedFrameConfig}}'s getters. Therefore, a {{FencedFrameConfig}} that
is created and exposed to the web platform is effectively immutable even if its underlying
[=fenced frame config=] is technically "pending", and will finish resolving completely later.
can be inspected through {{FencedFrameConfig}}'s getters. Therefore, a {{FencedFrameConfig}} that is
created and exposed to the web platform is effectively immutable even if the [=fenced frame config=]
represented by the [=fencedframe/config=]'s [=fencedframeconfig/urn=] is technically "pending", and
will finish resolving completely later.

Each [=fenced frame config mapping=] has a <dfn for="fenced frame config mapping">maximum number of
configs</dfn>, which is implementation-defined. The [=fenced frame config mapping/maximum number of
Expand Down Expand Up @@ -1182,46 +1183,43 @@ Each {{FencedFrameConfig}} has:

1. If |forStorage| is true, then throw a {{DataCloneError}} {{DOMException}}.

1. Set |serialized|.`[[Urn]]` to the value of |value|'s [=fencedframeconfig/urn=] attribute.
1. Set |serialized|.\[[Urn]] to |value|'s [=fencedframeconfig/urn=].

1. Set |serialized|.`[[SharedStorageContext]]` to the value of |value|'s [=fencedframeconfig/
sharedStorageContext=] attribute.
1. Set |serialized|.\[[SharedStorageContext]] to |value|'s [=fencedframeconfig/
sharedStorageContext=].

1. Set |serialized|.`[[ContainerWidth]]` to the value of |value|'s [=fencedframeconfig/
containerWidth=] attribute.
1. Set |serialized|.\[[ContainerWidth]] to |value|'s [=fencedframeconfig/
containerWidth=].

1. Set |serialized|.`[[ContainerHeight]]` to the value of |value|'s [=fencedframeconfig/
containerHeight=] attribute.
1. Set |serialized|.\[[ContainerHeight]] to |value|'s [=fencedframeconfig/
containerHeight=].

1. Set |serialized|.`[[ContentWidth]]` to the value of |value|'s [=fencedframeconfig/
contentWidth=] attribute.
1. Set |serialized|.\[[ContentWidth]] to |value|'s [=fencedframeconfig/
contentWidth=].

1. Set |serialized|.`[[ContentHeight]]` to the value of |value|'s [=fencedframeconfig/
contentHeight=] attribute.
1. Set |serialized|.\[[ContentHeight]] to |value|'s [=fencedframeconfig/
contentHeight=].


</div>

<div algorithm="FencedFrameConfig deserializer">
Their
[=deserialization steps=], given |serialized|, |value|, and <var ignore> targetRealm</var> are:
Their [=deserialization steps=], given |serialized|, |value|, and <var ignore> targetRealm</var>
are:

1. Initialize |value|'s [=fencedframeconfig/urn=] attribute to |serialized|.`[[Urn]]`.
1. Initialize |value|'s [=fencedframeconfig/urn=] to |serialized|.\[[Urn]].

1. Initialize |value|'s [=fencedframeconfig/sharedStorageContext=] attribute to |serialized|.`
[[SharedStorageContext]]`.
1. Initialize |value|'s [=fencedframeconfig/sharedStorageContext=] to
|serialized|.\[[SharedStorageContext]].

1. Initialize |value|'s [=fencedframeconfig/containerWidth=] attribute to |serialized|.
`[[ContainerWidth]]`.
1. Initialize |value|'s [=fencedframeconfig/containerWidth=] to |serialized|.\[[ContainerWidth]].

1. Initialize |value|'s [=fencedframeconfig/containerHeight=] attribute to |serialized|.
`[[ContainerHeight]]`.
1. Initialize |value|'s [=fencedframeconfig/containerHeight=] to
|serialized|.\[[ContainerHeight]].

1. Initialize |value|'s [=fencedframeconfig/contentWidth=] attribute to |serialized|.
`[[ContentWidth]]`.
1. Initialize |value|'s [=fencedframeconfig/contentWidth=] to |serialized|.\[[ContentWidth]].

1. Initialize |value|'s [=fencedframeconfig/contentHeight=] attribute to |serialized|.
`[[ContentHeight]]`.
1. Initialize |value|'s [=fencedframeconfig/contentHeight=] to |serialized|.\[[ContentHeight]].
</div>

<h3 id=fence-interface>The {{Fence}} interface</h3>
Expand Down Expand Up @@ -1353,16 +1351,16 @@ Several APIs specific to fenced frames are defined on the {{Fence}} interface.
[=fenced frame config/container size=]'s [=size/height=]

: [=fencedframeconfig/contentWidth=]
:: null if |config|'s [=fenced frame config/content size=] is null, {{OpaqueProperty}} if
|config|'s [=fenced frame config/content size=]'s [=content size/visibility=] is
[=visibility/opaque=], otherwise |config|'s [=fenced frame config/content size=]'s
[=size/width=]
:: null if |config|'s [=fenced frame config/content size=] is null, the `"opaque"`
{{OpaqueProperty}} if |config|'s [=fenced frame config/content size=]'s [=content
size/visibility=] is [=visibility/opaque=], otherwise |config|'s [=fenced frame
config/content size=]'s [=size/width=]

: [=fencedframeconfig/contentHeight=]
:: null if |config|'s [=fenced frame config/content size=] is null, {{OpaqueProperty}} if
|config|'s [=fenced frame config/content size=]'s [=content size/visibility=] is
[=visibility/opaque=], otherwise |config|'s [=fenced frame config/content size=]'s
[=size/height=]
:: null if |config|'s [=fenced frame config/content size=] is null, the `"opaque"`
{{OpaqueProperty}} if |config|'s [=fenced frame config/content size=]'s [=content
size/visibility=] is [=visibility/opaque=], otherwise |config|'s [=fenced frame
config/content size=]'s [=size/height=]

1. [=list/Append=] |newConfig| to |results|.

Expand Down Expand Up @@ -2144,8 +2142,8 @@ CORP violation report=] algorithm, as leaving it unfenced may cause a privacy le
</div>

<div algorithm=navigate>
Modify the beginning sentence of [[HTML]]'s [=navigate=] algorithm to include an extra parameter:
an optional [=string=] |sharedStorageContext| (default null).
Modify the definition of [[HTML]]'s [=navigate=] algorithm to include an extra parameter: an
optional [=string=] |sharedStorageContext| (default null).

Modify step 7 of [[HTML]]'s [=navigate=] algorithm to include the following condition:

Expand Down