Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on main #955

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Fix build on main #955

merged 3 commits into from
Feb 15, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 15, 2024

Main was broken after #949
ALoadoutSynchronizer() was expected to have a single parameter by many subclasses or users, which broke when the Os param was added

@Al12rs Al12rs requested a review from a team February 15, 2024 16:24
@Al12rs Al12rs self-assigned this Feb 15, 2024
@Al12rs
Copy link
Contributor Author

Al12rs commented Feb 15, 2024

Tests are broken because they don't have access to IOSInformation. Does anyone know what .Add function adds that in Startup.cs?

Edit:
Found it, was AddCrossPlatform()

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f0c1f95) 0.00% compared to head (8a46080) 58.65%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #955       +/-   ##
=========================================
+ Coverage      0   58.65%   +58.65%     
=========================================
  Files         0      630      +630     
  Lines         0    20272    +20272     
  Branches      0     1558     +1558     
=========================================
+ Hits          0    11891    +11891     
- Misses        0     8015     +8015     
- Partials      0      366      +366     
Flag Coverage Δ
Linux 58.02% <60.00%> (?)
Windows 57.91% <60.00%> (?)
clean_environment_tests 58.64% <60.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ons.Loadouts.Synchronizers/ALoadoutSynchronizer.cs 92.30% <100.00%> (ø)
tests/NexusMods.CLI.Tests/Startup.cs 0.00% <0.00%> (ø)
tests/NexusMods.DataModel.Tests/Startup.cs 0.00% <0.00%> (ø)

... and 627 files with indirect coverage changes

@Sewer56 Sewer56 merged commit 63b31f3 into main Feb 15, 2024
4 checks passed
@Al12rs Al12rs deleted the main_build_fix branch February 15, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants