Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Setting Execute Bit on Linux based on Extension #949

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Feb 14, 2024

Fixes #924

Basic test included.
Draft until PR in Paths is merged,

@Sewer56 Sewer56 added Bug Something isn't working os-linux This affects Linux related code. os-macOS This affects macOS/OSX related code. labels Feb 14, 2024
@Sewer56 Sewer56 requested a review from a team February 14, 2024 21:31
@Sewer56 Sewer56 self-assigned this Feb 14, 2024
@Sewer56 Sewer56 marked this pull request as ready for review February 14, 2024 22:40
@codecov-commenter
Copy link

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (8bd7919) 55.28% compared to head (6f98411) 58.47%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
+ Coverage   55.28%   58.47%   +3.19%     
==========================================
  Files         620      626       +6     
  Lines       20058    20207     +149     
  Branches     1545     1554       +9     
==========================================
+ Hits        11089    11817     +728     
+ Misses       8620     8034     -586     
- Partials      349      356       +7     
Flag Coverage Δ
Linux 57.81% <12.90%> (+3.07%) ⬆️
Windows 57.74% <3.22%> (+3.18%) ⬆️
clean_environment_tests 58.45% <16.12%> (+3.18%) ⬆️
network_tests ?
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ons.Loadouts.Synchronizers/ALoadoutSynchronizer.cs 92.21% <85.71%> (-0.14%) ⬇️
...sMods.DataModel.Tests/ALoadoutSynchronizerTests.cs 0.00% <0.00%> (ø)

... and 68 files with indirect coverage changes

Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but didn't test being on windows.

Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@Sewer56 Sewer56 merged commit f0c1f95 into main Feb 15, 2024
2 of 4 checks passed
@Al12rs Al12rs mentioned this pull request Feb 15, 2024
@erri120 erri120 deleted the execute-bit branch February 26, 2024 14:33
@erri120 erri120 changed the title Add Support for Setting Execute Bit on Linux based on Extension (fixes #924) Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working os-linux This affects Linux related code. os-macOS This affects macOS/OSX related code.
4 participants