Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Tabs #708

Merged
merged 37 commits into from
Oct 18, 2023
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Oct 11, 2023

Part of #674 (after #688, and #704). Closes #676.

TODO:

  • virtualize/cache views
  • Adds tabs to panels.
  • Adds missing icons.
  • Some styling.
out.mp4
@erri120 erri120 added this to the v0.3 milestone Oct 11, 2023
@erri120 erri120 self-assigned this Oct 11, 2023
@erri120 erri120 changed the title **WIP**: Workspace: Tabs Oct 11, 2023
@erri120 erri120 mentioned this pull request Oct 11, 2023
45 tasks
@erri120 erri120 marked this pull request as ready for review October 11, 2023 13:35
@github-actions
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@erri120 erri120 changed the title WIP: Workspace Tabs Oct 11, 2023
@erri120 erri120 force-pushed the issue-674-panels-part-3-tabs branch 2 times, most recently from 7a25601 to 4eddab5 Compare October 11, 2023 13:46
@github-actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@erri120 erri120 requested a review from a team October 11, 2023 13:48
@erri120 erri120 mentioned this pull request Oct 12, 2023
6 tasks
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #708 (373ee24) into main (c5d7ad4) will decrease coverage by 1.11%.
Report is 3 commits behind head on main.
The diff coverage is 22.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   64.86%   63.76%   -1.11%     
==========================================
  Files         660      669       +9     
  Lines       19395    19788     +393     
  Branches     1293     1305      +12     
==========================================
+ Hits        12580    12617      +37     
- Misses       6489     6842     +353     
- Partials      326      329       +3     
Flag Coverage Δ
Linux 63.09% <22.62%> (-1.14%) ⬇️
Windows 62.98% <22.62%> (-1.11%) ⬇️
clean_environment_tests 63.74% <22.62%> (-1.11%) ⬇️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.App.UI/Services.cs 98.13% <100.00%> (+0.07%) ⬆️
src/NexusMods.App.UI/Theme/IconStyles.xaml 98.36% <100.00%> (+0.58%) ⬆️
src/NexusMods.App.UI/Theme/TextBlockStyles.xaml 99.46% <100.00%> (ø)
src/NexusMods.App.UI/WorkspaceSystem/IconUtils.cs 100.00% <100.00%> (ø)
src/NexusMods.App.UI/WorkspaceSystem/MathUtils.cs 100.00% <100.00%> (ø)
...eSystem/Workspace/WorkspacePlaygroundView.axaml.cs 0.00% <ø> (ø)
...ceSystem/Workspace/WorkspacePlaygroundViewModel.cs 0.00% <0.00%> (ø)
...rc/NexusMods.App.UI/Controls/Dummy/DummyView.axaml 0.00% <0.00%> (ø)
...paceSystem/Workspace/WorkspacePlaygroundView.axaml 0.00% <0.00%> (ø)
...UI/WorkspaceSystem/Workspace/WorkspaceViewModel.cs 0.00% <0.00%> (ø)
... and 14 more

... and 4 files with indirect coverage changes

@erri120 erri120 force-pushed the issue-674-panels-part-3-tabs branch from 22dda27 to 32e4287 Compare October 16, 2023 13:21
@erri120 erri120 merged commit 9d9ce50 into Nexus-Mods:main Oct 18, 2023
5 of 7 checks passed
@erri120 erri120 deleted the issue-674-panels-part-3-tabs branch October 18, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants