Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Layout State and Image Generation #704

Merged
merged 12 commits into from
Oct 11, 2023

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Oct 10, 2023

Part of #674 (after #688) and #676.

Changes:

  • Adds GridUtils
    • generate every possible layout state when layout changes
    • generate new state when a panel should close
  • Adds IconUtils
out.mp4
@erri120 erri120 added this to the v0.3 milestone Oct 10, 2023
@erri120 erri120 requested a review from a team October 10, 2023 08:52
@erri120 erri120 self-assigned this Oct 10, 2023
@erri120 erri120 mentioned this pull request Oct 10, 2023
45 tasks
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #704 (259d111) into main (cc18214) will increase coverage by 0.60%.
The diff coverage is 56.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   63.39%   64.00%   +0.60%     
==========================================
  Files         646      650       +4     
  Lines       18513    18703     +190     
  Branches     1192     1226      +34     
==========================================
+ Hits        11737    11970     +233     
+ Misses       6477     6429      -48     
- Partials      299      304       +5     
Flag Coverage Δ
Linux 63.30% <56.72%> (+0.58%) ⬆️
Windows 62.77% <56.72%> (+0.12%) ⬆️
clean_environment_tests 63.97% <56.72%> (+0.59%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.App.UI/Services.cs 98.05% <100.00%> (+0.05%) ⬆️
src/NexusMods.App.UI/WorkspaceSystem/IconUtils.cs 100.00% <100.00%> (ø)
src/NexusMods.App.UI/WorkspaceSystem/MathUtils.cs 100.00% <100.00%> (+25.00%) ⬆️
...I/WorkspaceSystem/Workspace/WorkspaceView.axaml.cs 0.00% <ø> (ø)
...paceSystem/AddPanelButton/AddPanelButtonView.axaml 0.00% <0.00%> (ø)
...ds.App.UI/WorkspaceSystem/Panel/PanelView.axaml.cs 0.00% <0.00%> (ø)
...sMods.App.UI/WorkspaceSystem/Panel/PanelView.axaml 0.00% <0.00%> (ø)
...eSystem/Workspace/WorkspacePlaygroundView.axaml.cs 0.00% <0.00%> (ø)
src/NexusMods.App.UI/WorkspaceSystem/GridUtils.cs 94.89% <94.89%> (ø)
...ods.App.UI/WorkspaceSystem/Panel/PanelViewModel.cs 0.00% <0.00%> (ø)
... and 6 more

... and 7 files with indirect coverage changes

@erri120 erri120 mentioned this pull request Oct 10, 2023
6 tasks
@erri120 erri120 mentioned this pull request Oct 11, 2023
4 tasks
@halgari halgari merged commit c5d7ad4 into Nexus-Mods:main Oct 11, 2023
6 of 7 checks passed
@erri120 erri120 deleted the issue-674-panels-part-2 branch October 11, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants