Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod (downloads) Library UI initial impl #1268

Merged
merged 34 commits into from
Apr 29, 2024
Merged

Mod (downloads) Library UI initial impl #1268

merged 34 commits into from
Apr 29, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Apr 24, 2024 •
edited
Loading

Related to #1210 and #1155

  • This adds the page, the ui layouts, the bindings, and the Add button functionality.
  • Most columns are empty for now
  • Page needs to be closed and reopened to refresh the data for now
  • This also adds Icons to most of the pages
  • Remaining work will be addressed in future PRs

TODO:

  • Add Left menu entry and icon (use the new navigation system from Add NavigationControl #1266 )
  • Update Page name to "Library"
  • Update Page icon to library icon
  • Update Page name in discovery details to Library
  • Review UI to match colors and fonts from design

Bumping out to future PRs:

  • Tracking issue: Mod Library Refinements #1284
  • Make list update in real-time (get observable stream from database) (better wait for Download manager to MNemonicDB #1276 )
  • Downloaded date/time data (put "Manually added" for mod archives not downloaded through the app)
  • Use the Nexus mod name for archives that come from nexus instead of the file name.
  • Version data if available (will not be for archives that don't come from nexus, but for manual archives that come from nexus it should be possible to obtain the data with an API call, or by parsing the archive name for the embedded version number)
  • Added column data (not sure how to implement this yet, loadouts and mods probably need to be moved to Mnemonic first)
  • Filter out archives that are not manually added or downloaded (don't show nested archives like Installer.dat from SMAPI)
@Al12rs
WIP: add page
5a61dbb
@Al12rs
Create files
a41f09d
@Al12rs
WIP: view work
2cf0976
@Al12rs
Add page discovery details
cc3940e
@Al12rs
Rename to FileOriginsPage
6d177f1
@Al12rs
WIP
1892701
@Al12rs
WIP
432b0b5
@Al12rs
Add file origin entry vm
83e90db
@Al12rs
Add API to install DownloadAnalysis.Model items instead of DownloadIds
e00ffae
@Al12rs
Implement name and adding the mod
3dd088f
@Al12rs
Merge branch 'main' into feat/1155-downloads-library-ui
f98e05a 
# Conflicts:
#	src/NexusMods.App.UI/NexusMods.App.UI.csproj
#	src/NexusMods.App.UI/Resources/Language.Designer.cs
#	src/NexusMods.App.UI/Resources/Language.resx
@Al12rs
WIP bindings
67d1908
@Al12rs
Add page to the services
64c951c
@Al12rs
Fix binding issues
ea9021d
@Al12rs
Fix Install button not working
6bbca19
@Al12rs
Disable Version column and Date column since we don't have data.
2b9b55e 
Fix DataGrid colums not adapting to content size
@Al12rs
Add page title and page icon
dc6cc9d
@Al12rs
Added page icons to pages:
2b6484e 
- LoadoutGrid
- MyGames
- In progress downloads
@Al12rs
Translate headers
0818800
@Al12rs Al12rs self-assigned this Apr 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.
@Al12rs
Merge branch 'main' into feat/1155-downloads-library-ui
05d5be2 
# Conflicts:
#	src/NexusMods.App.UI/LeftMenu/Home/HomeLeftMenuViewModel.cs
#	src/NexusMods.App.UI/Pages/LoadoutGrid/LoadoutGridViewModel.cs
@github-actions GitHub Actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.
@github-actions GitHub Actions
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.
@Al12rs
Merge branch 'main' into feat/1155-downloads-library-ui
00b1911 
# Conflicts:
#	src/NexusMods.App.UI/Pages/Downloads/InProgressViewModel.cs
#	src/NexusMods.App.UI/Pages/MyGames/MyGamesViewModel.cs
#	src/NexusMods.App.UI/Resources/Language.resx
@github-actions GitHub Actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.
@Al12rs Al12rs marked this pull request as ready for review April 29, 2024 10:37
@Al12rs Al12rs mentioned this pull request Apr 29, 2024
Closed
8 tasks
@erri120 erri120 self-requested a review April 29, 2024 10:46
erri120
erri120 requested changes Apr 29, 2024
View reviewed changes
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginsPage.cs Show resolved Hide resolved
src/NexusMods.App.UI/WorkspaceSystem/PanelTabHeader/PanelTabHeaderView.axaml Outdated Show resolved Hide resolved
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginEntry/IFileOriginEntryViewModel.cs Outdated
Comment on lines 9 to 11
string Version { get; init; }
string Size { get; init; }
string Date { get; init; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't be strings. If they stay as strings, then they won't be sortable.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We store versions as strings, and comparisons there should work.
I'm not really sure how to show "-" in case of unknown date though
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We store versions as strings, and comparisons there should work.

Right.

I'm not really sure how to show "-" in case of unknown date though

Hijack how the dates are displayed. Use Optional<DateTime> or something, if it's None you display - or just display nothing.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doing a direct binding from the property to the DataGridTextColumn, there is no conversion step in the code behind or anything like that. I'd prefer not to do something like the LoadoutDataGrid where each column needs a custom view, vm, type, and an special definition.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to the things to to do #1284
Copy link
Member

@erri120 erri120 Apr 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to update the binding and change the string formatting or use a converter. If that doesn't work, you can always make the text columns into template columns, which is probably easier.
@Al12rs Al12rs merged commit 44f21bb into main Apr 29, 2024
7 checks passed
@Al12rs Al12rs deleted the feat/1155-downloads-library-ui branch April 29, 2024 13:41
This was referenced Apr 29, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Al12rs @erri120