Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NavigationControl #1266

Merged
merged 13 commits into from
Apr 29, 2024
Merged

Add NavigationControl #1266

merged 13 commits into from
Apr 29, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Apr 24, 2024 •
edited
Loading

Resolves #942.

out.mp4
@erri120 erri120 self-assigned this Apr 24, 2024
@erri120 erri120 changed the title WIP: Add NavigationControl Apr 24, 2024
@erri120 erri120 marked this pull request as ready for review April 24, 2024 13:35
@erri120 erri120 requested a review from a team April 24, 2024 13:37
@Al12rs
Copy link
Contributor

Al12rs commented Apr 24, 2024

So this doesn't handle buttons that are inside a page right? e.g. DiagnisticList or LoadoutGrid
@Al12rs Al12rs mentioned this pull request Apr 24, 2024
Merged
11 tasks
@Al12rs
Copy link
Contributor

Al12rs commented Apr 24, 2024

I haven't finished review of the new button code. I might sneak that in tomorrow morning
@erri120 erri120 force-pushed the feat/942-navigation-control branch from 057f4f4 to 154d956 Compare April 25, 2024 08:56
Al12rs
Al12rs requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "Open in new panel" context menu while you already have 4 panels throws an exception
image
@Al12rs
Copy link
Contributor

Al12rs commented Apr 25, 2024 •
edited
Loading

Exception needs to be fixed, the rest looks good. We are of course missing all the navigation from inside Pages. I'm guessing that will be in another pr
@Al12rs
Copy link
Contributor

Al12rs commented Apr 25, 2024

Ah Settings button navigation in the top bar is missing
@erri120
Copy link
Member Author

erri120 commented Apr 25, 2024

Everything that opens pages should now be using the new navigation control.
@erri120 erri120 requested a review from Al12rs April 25, 2024 10:05
@github-actions GitHub Actions
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.
@erri120 erri120 requested a review from Al12rs April 29, 2024 07:53
@github-actions GitHub Actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.
@erri120 erri120 merged commit bcc3679 into Nexus-Mods:main Apr 29, 2024
7 checks passed
@erri120 erri120 deleted the feat/942-navigation-control branch April 29, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@erri120 @Al12rs