Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Support for Enhanced Tree Node Icons #1072

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Mar 18, 2024

Review after:

This PR adds support for displaying file icons in View Mod Files and Advanced Installer.
I.e. Start of '2nd phase' of Viewing/Diffing files.

20240318_05h43m02s_

20240318_05h34m33s_Nexus_Mods_App

Nothing more, nothing less.
As demo'd at the end of last week, but with AdvancedInstaller, too!

Checks off another box in:

I also made FileTreeNodeDesignViewModel inherit from FileTreeNodeViewModel, saving a few lines of code. Originally this was a piece of feedback on the original View Mod Files PR. At the time it wasn't as easily possible, as we stored data a bit differently. But now, there is no problem.


Note: This is marked as a draft because it's blocked as the PR on NexusMods.Paths is still open, and we don't have a new package.

@Sewer56 Sewer56 added meta-improvement An issue that improves an existing feature BLOCKED This ticket cannot be completed until another ticket is completed Design UI/UX This is related to the UI. area-advanced-installer labels Mar 18, 2024
@Sewer56 Sewer56 requested a review from a team March 18, 2024 05:50
@Sewer56 Sewer56 self-assigned this Mar 18, 2024
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@Al12rs
Copy link
Contributor

Al12rs commented Mar 21, 2024

@Sewer56 rebase and mark as ready for review and we can get this merged as well

Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@Sewer56 Sewer56 marked this pull request as ready for review March 21, 2024 15:15
@Sewer56 Sewer56 merged commit 34f6f05 into main Mar 25, 2024
7 of 8 checks passed
@Al12rs Al12rs deleted the enhanced-tree-node-icons branch March 25, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-advanced-installer BLOCKED This ticket cannot be completed until another ticket is completed Design UI/UX This is related to the UI. meta-improvement An issue that improves an existing feature
2 participants