-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: Support for Enhanced Tree Node Icons #1072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sewer56
added
meta-improvement
An issue that improves an existing feature
BLOCKED
This ticket cannot be completed until another ticket is completed
Design UI/UX
This is related to the UI.
area-advanced-installer
labels
Mar 18, 2024
17 tasks
This PR conflicts with |
@Sewer56 rebase and mark as ready for review and we can get this merged as well |
Sewer56
force-pushed
the
enhanced-tree-node-icons
branch
from
March 21, 2024 15:14
18ba21b
to
d4cb6a8
Compare
This PR doesn't conflict with |
Al12rs
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-advanced-installer
BLOCKED
This ticket cannot be completed until another ticket is completed
Design UI/UX
This is related to the UI.
meta-improvement
An issue that improves an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review after:
This PR adds support for displaying file icons in
View Mod Files
andAdvanced Installer
.I.e. Start of '2nd phase' of Viewing/Diffing files.
Nothing more, nothing less.
As demo'd at the end of last week, but with AdvancedInstaller, too!
Checks off another box in:
I also made
FileTreeNodeDesignViewModel
inherit fromFileTreeNodeViewModel
, saving a few lines of code. Originally this was a piece of feedback on the originalView Mod Files
PR. At the time it wasn't as easily possible, as we stored data a bit differently. But now, there is no problem.Note: This is marked as a draft because it's blocked as the PR on
NexusMods.Paths
is still open, and we don't have a new package.