Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed: Don't use custom join in GamePathNode & Update Paths Library #1067

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Mar 14, 2024

Avoids custom logic for path creation.
Ticks off a box in

This is set as 'draft' because waiting for Paths PR merges & NuGet

@Sewer56 Sewer56 requested a review from a team March 14, 2024 03:17
@Sewer56 Sewer56 self-assigned this Mar 14, 2024
@Sewer56 Sewer56 added the BLOCKED This ticket cannot be completed until another ticket is completed label Mar 14, 2024
@erri120
Copy link
Member

erri120 commented Mar 14, 2024

What's blocking this?

@Sewer56
Copy link
Member Author

Sewer56 commented Mar 14, 2024

I just wanted to update paths lib on this branch while I was at it. Nothing else really.

@Sewer56 Sewer56 marked this pull request as ready for review March 21, 2024 14:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.95%. Comparing base (5c4ef18) to head (d599ac8).
Report is 199 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
- Coverage   54.82%   53.95%   -0.87%     
==========================================
  Files         662      673      +11     
  Lines       21997    22348     +351     
  Branches     1717     1715       -2     
==========================================
- Hits        12059    12057       -2     
- Misses       9541     9896     +355     
+ Partials      397      395       -2     
Flag Coverage Δ
Linux 53.29% <100.00%> (-0.85%) ⬇️
Windows 53.20% <100.00%> (-0.86%) ⬇️
clean_environment_tests 53.94% <100.00%> (-0.87%) ⬇️
macOS 52.76% <100.00%> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ds.Abstractions.GameLocators/Trees/GamePathNode.cs 95.08% <100.00%> (-0.08%) ⬇️
....Games.RedEngine/ModInstallers/AppearancePreset.cs 89.47% <100.00%> (ø)

... and 83 files with indirect coverage changes

@Sewer56 Sewer56 merged commit d4322f4 into main Mar 25, 2024
6 checks passed
@erri120 erri120 deleted the update-paths branch March 27, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED This ticket cannot be completed until another ticket is completed
3 participants