Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IsExpanded to Child Items #1053

Merged
merged 81 commits into from
Mar 14, 2024
Merged

Move IsExpanded to Child Items #1053

merged 81 commits into from
Mar 14, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Mar 12, 2024

Checks off second box in
#1048

Successor to:

Am on my phone, so no legendary elaborate descriptions. Besides, I've been meming hard enough today.

Removed the bug at its core by avoiding using unnecessary grids inside the layouts, instead using StackPanels where more appropriate. This uses less resources anyway.

I also removed unused x:Name declarations, shortening the LoC by a bit.
Sewer56 and others added 16 commits March 7, 2024 15:20
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@Sewer56 Sewer56 requested a review from a team March 13, 2024 05:30
@Sewer56 Sewer56 self-assigned this Mar 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 55.35%. Comparing base (5a6319b) to head (8356c0b).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
- Coverage   55.38%   55.35%   -0.04%     
==========================================
  Files         659      659              
  Lines       21886    21903      +17     
  Branches     1709     1709              
==========================================
+ Hits        12122    12124       +2     
- Misses       9364     9378      +14     
- Partials      400      401       +1     
Flag Coverage Δ
Linux 54.67% <35.71%> (+0.02%) ⬆️
Windows 54.60% <35.71%> (+0.03%) ⬆️
clean_environment_tests 55.33% <35.71%> (-0.04%) ⬇️
macOS 54.10% <35.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....UI/Content/Left/ModContent/ModContentViewModel.cs 96.00% <100.00%> (ø)
...Content/TreeEntry/IModContentTreeEntryViewModel.cs 100.00% <ø> (ø)
...dContent/TreeEntry/ModContentTreeEntryViewModel.cs 87.17% <100.00%> (+0.33%) ⬆️
...ht/Preview/TreeEntry/IPreviewTreeEntryViewModel.cs 100.00% <ø> (ø)
...ght/Preview/TreeEntry/PreviewTreeEntryViewModel.cs 95.83% <100.00%> (+0.08%) ⬆️
...ocation/TreeEntry/ISelectableTreeEntryViewModel.cs 100.00% <ø> (ø)
....UI/Controls/Trees/Files/IFileTreeNodeViewModel.cs 0.00% <ø> (ø)
...rc/NexusMods.App.UI/Helpers/TreeDataGridHelpers.cs 71.42% <ø> (ø)
...Location/TreeEntry/SelectableTreeEntryViewModel.cs 53.19% <0.00%> (-1.16%) ⬇️
...ontrols/Trees/Files/FileTreeNodeDesignViewModel.cs 0.00% <0.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erri said this is fine if not ideal

@Sewer56 Sewer56 merged commit 5ace2b8 into main Mar 14, 2024
6 checks passed
@Al12rs Al12rs deleted the move-isexpanded branch March 14, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants