-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View Mod Contents First Draft & TreeDataGrid Improvements #1023
Conversation
Removed the bug at its core by avoiding using unnecessary grids inside the layouts, instead using StackPanels where more appropriate. This uses less resources anyway. I also removed unused x:Name declarations, shortening the LoC by a bit.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
- Coverage 56.80% 55.30% -1.50%
==========================================
Files 645 660 +15
Lines 21248 21888 +640
Branches 1656 1710 +54
==========================================
+ Hits 12069 12105 +36
- Misses 8783 9387 +604
Partials 396 396
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/NexusMods.App.UI/Controls/Trees/Files/FileTreeNodeViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/Trees/Files/FileTreeNodeView.axaml.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/Trees/Files/FileTreeNodeView.axaml
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/Trees/Files/FileTreeNodeView.axaml
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/Trees/Files/FileTreeNodeView.axaml
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/Trees/Files/FileTreeNodeDesignViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/ModInfo/ModFiles/ModFilesViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/ModInfo/ModFiles/ModFilesViewModFilesDesignModFilesViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Pages/ModInfo/ModInfoViewModInfoDesignModInfoViewModel.cs
Outdated
Show resolved
Hide resolved
src/Themes/NexusMods.Themes.NexusFluentDark/NexusMods.Themes.NexusFluentDark.csproj
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/ModInfo/ModFiles/ViewModFilesView.axaml.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
lub nie jest już już dostępny w oryginalnej lokalizacji.</value> | ||
</data> | ||
<data name="ViewModInfoPage_NotFound_Title" xml:space="preserve"> | ||
<value>Mod Nie Znaleziony</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about such an alternative?
<value>Mod Nie Znaleziony</value> | |
<value>Nie znaleziono moda</value> |
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
lub nie jest już już dostępny w oryginalnej lokalizacji.</value> | ||
</data> | ||
<data name="ViewModInfoPage_NotFound_Title" xml:space="preserve"> | ||
<value>Mod Nie Znaleziony</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about such an alternative?
<value>Mod Nie Znaleziony</value> | |
<value>Nie znaleziono moda</value> |
Co-authored-by: Patriot99 <31535921+Patriot99@users.noreply.github.com>
I will ignore translations fixes for review since we can deal with them after this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved stuff to #1048
src/NexusMods.App.UI/Controls/ModInfo/ViewModFiles/ViewModFilesView.axaml.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/ModInfo/ViewModFiles/ViewModFilesView.axaml.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/ModInfo/ModFiles/ViewModFilesView.axaml.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single leftover thing to fix and I think we can merge, all the rest should be handled in future PRs.
Any additional feedback (e.g. translations) can be added as an issue or items to #1048
public CurrentModInfoSection Section { get; set; } | ||
|
||
[Reactive] | ||
public IViewModelInterface SectionViewModel { get; set; } = default!; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a puppy died somewhere when you wrote this. Make this nullable or set it to the DummyLoadingViewModel
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining issues will be handled in future PRs.
fixes #989
Implementation includes:
AGamePathTree
).Additional changes:
AdvancedInstaller
dialogs now use a newTreeDataGrid
helper to avoid repeated code.Grid
use.x:Name
declarations.