Enhance view owner validation

trinodb · Apr 19, 2021 · f4dcf75 · f4dcf75
1 parent 60681db
commit f4dcf75
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java b/core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
@@ -1470,6 +1470,9 @@ private List<ConnectorViewDefinition.ViewColumn> translateMaterializedViewColumn
 
         private Scope createScopeForView(Table table, QualifiedObjectName name, Optional<Scope> scope, ConnectorViewDefinition view)
         {
+            if (!view.isRunAsInvoker() && view.getOwner().isEmpty()) {
+                throw semanticException(INVALID_VIEW, table, "Owner must be present in view '%s' with SECURITY DEFINER mode", name);
+            }
             return createScopeForView(table, name, scope, view.getOriginalSql(), view.getCatalog(), view.getSchema(), view.getOwner(), view.getColumns());
         }
 

diff --git a/core/trino-main/src/test/java/io/trino/sql/analyzer/TestAnalyzer.java b/core/trino-main/src/test/java/io/trino/sql/analyzer/TestAnalyzer.java
@@ -3242,7 +3242,7 @@ public void setup()
                 ImmutableList.of(new ViewColumn("a", BIGINT.getTypeId())),
                 Optional.empty(),
                 Optional.empty(),
-                false);
+                true);
         inSetupTransaction(session -> metadata.createView(
                 session,
                 tableViewAndMaterializedView,