Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(26228-padding-bytes) tor-spec padding stuff; tickets 26228, 26870, 26871 (tor-spec only) #28

Closed
wants to merge 4 commits into from
Closed

(26228-padding-bytes) tor-spec padding stuff; tickets 26228, 26870, 26871 (tor-spec only) #28

wants to merge 4 commits into from

Conversation

dmr-x
Copy link
Contributor

@dmr-x dmr-x commented Jul 18, 2018

dmr-x and others added 4 commits July 18, 2018 21:22
@dmr-x
Update spec with SHOULD/MUST behavior for padding bytes
7b1a76c 
In doing so, specify a general behavior for padding bytes in Section 3
and cross-reference other locations to this, to aid in future
consistency.

Also clarify a few vague parts of the prior wording.

Fixes #26860.
@teor2345
tor-spec: Clarify padding bytes in VPADDING, PADDING, and DROP cells
f6d9d37 
Closes 26870.
@teor2345
fixup! tor-spec: Clarify padding bytes in VPADDING, PADDING, and DROP…
de454fe 
… cells
@teor2345
tor-spec: Prop#289: RELAY cell padding should be randomised
b22b401 
Updates tor-spec for 26871
@dmr-x
Copy link
Contributor Author

dmr-x commented Jul 24, 2018

@nmathewson: please note when squashing this that my description for 7b1a76c has the wrong ticket number! s/26860/26228/ (please fix).
@dmr-x dmr-x changed the title (26228-padding-bytes) Update spec with SHOULD/MUST behavior for padding bytes Jul 24, 2018
@dmr-x dmr-x changed the title (26228-padding-bytes) padding stuff; tickets 26228, 26870, 26871 Jul 24, 2018
@teor2345
Copy link
Contributor

@nmathewson: please note when squashing this that my description for 7b1a76c has the wrong ticket number! s/26860/26228/ (please fix).

@dmr-x, you could force-push this fix yourself, if you'd like.
@dmr-x
Copy link
Contributor Author

dmr-x commented Aug 13, 2018 •
edited
Loading

@teor2345 (cc: @nmathewson)
Sorry, I didn't know the policy on force-pushing; I didn't want to create hassle.
I saw fixup commits, so I assumed that force-pushing was a no-no.

Looks like I'm way too late now to fix this. Oh well - next time I'll know better! Thanks!
@dmr-x
Copy link
Contributor Author

dmr-x commented Aug 13, 2018

Squashed and merged as 608c4a2.
@dmr-x dmr-x closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@dmr-x @teor2345