(26860-decryption-order) Update spec to match correct decryption order #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #26860.
The section now consists of: * forward encryption at the client * forward decryption at ORs * backward encryption at the end (exit) * backward decryption at the client Part of 26860.
Also generalised the EXTENDED to CREATED section so it covers EXTENDED2 to CREATED2. Closes 26859.
And perhaps they never were?
tlyu
reviewed
Jul 19, 2018
tor-spec.txt
Outdated
| @@ -992,6 +992,10 @@ see tor-design.pdf. | |||
| different RSA identity, it SHOULD NOT attempt to make another | |||
| connection: it should just fail and DESTROY the circuit. | |||
|
|
|||
| After checking relay identities, extending ORs generate a CREATE[2] | |||
| cell from the contents of the EXTEND[2] cell. See section 5.3 for | |||
There was a problem hiding this comment.
I think CREATE[2], etc. looks too much like a footnote or something. Maybe instead use CREATE or CREATE2 or CREATE/CREATE2?
Use */*2 instead of *[2]. Add more /*2.
|
Squashed and merged as 7ced619. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket