Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to single-file-per-client client auth UX. #23

Closed
wants to merge 1 commit into from

Conversation

asn-d6
Copy link
Member

@asn-d6 asn-d6 commented Jul 10, 2018

No description provided.

authenticate Alice.

If no "alice.keys" file is found, Tor is tasked with generating Alice's
keypair. To do so, Tor generates x25519 and ed25519 keypairs for Alice,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the service need to generate both keypairs? What if that client is enabled in desc auth but not in intro auth (via HiddenServiceAuthorizeClient)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case the service would need to indeed generate only the desc key.

I didn't end up describing the standard/desc/intro auth distinction in the spec patch because it would get too complex. Perhaps we should do it before proceeding tho.

@ppopth
Copy link

ppopth commented Jul 11, 2018

Do we still want to support three authtype keywords (desc, intro, and standard)?
standard means both desc and intro.

ed25519 private 66c1a77104d86461b6f98f73acf3cd229c80624495d2d74d6fda1e940080a96b
"""

E.1.3. Client side

A client who wants to register client authorization data for a hidden service
needs to add the following line to their torrc:

HidServAuth onion-address x25519-private-key ed25519-private-key
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to put the keyword before the key like HidServAuth onion-address x25519 [x25519-private-key] ed25519 [ed25519-private-key] ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea I guess.


Here is a suggested scheme for "alice.keys" for the latter scenario:
"""
alice
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need a name here? I think the name is already in the filename

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah might not be necessary indeed. I just wanted to make it clearer, and also make the filename contents self-explanatory.

@asn-d6 asn-d6 closed this Aug 8, 2018
@asn-d6
Copy link
Member Author

asn-d6 commented Aug 8, 2018

Obsoleted by PR #33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants