Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket26155 #10

Merged
merged 8 commits into from
Jun 25, 2018
Merged

Ticket26155 #10

merged 8 commits into from
Jun 25, 2018

Conversation

juga0
Copy link
Contributor

@juga0 juga0 commented May 22, 2018

No description provided.

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor wording changes, and then we're done.

generator and use the oldest value. This ensures all the generators
continue running.

If there are scanners that do not run continuously, they SHOULD be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generators

Copy link
Contributor

@teor2345 teor2345 May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use "threads"

The Unix Epoch time in seconds when the file was created.
It does not follow the KeyValue format for backwards
compatibility with version 1.0.0.
The Unix Epoch time in seconds of the most recent generator result.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change "generator result" to "generator bandwidth result".
Otherwise it's a bit confusing.

[Zero or one time.]

The date and time timestamp in ISO 8601 format and UTC time zone
of the most recent generator result.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"generator bandwidth result" for consistency

compatibility with version 1.0.0.
The Unix Epoch time in seconds of the most recent generator result.

If there are multiple generators which can fail independently,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing "scanners" with "generators" makes this paragraph more confusing.

Please use something like "threads or subprocesses".


If there are multiple generators which can fail independently,
implementations SHOULD take the most recent timestamp from each
generator and use the oldest value. This ensures all the generators
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to just use "thread" here.

@teor2345
Copy link
Contributor

Please add file created and latest bandwidth to the header of the example file in Appendix 2.

@juga0
Copy link
Contributor Author

juga0 commented May 23, 2018

Thanks for the comments, 3 last commits should solve what is commented here and in trac.tpo

@@ -128,6 +128,9 @@ It consists of:
If there are scanners that do not run continuously, they SHOULD be
excluded from the timestamp calculation.

If a generator does not have information about the most recent result,
it MUST NOT generate the file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense. And it is incomplete.

If there is no recent result, the generator MUST delete the old file, and it MUST NOT generate a new file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After our discussion on trac, this is complete, but it does not make sense.

If there are no recent results, the generator MUST NOT generate a new file.


If there are scanners that do not run continuously, they SHOULD be
If there are generators that do not run continuously, they SHOULD be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threads, not generators

@teor2345
Copy link
Contributor

teor2345 commented Jun 1, 2018

Looks good to me.
Please update the trac ticket to merge_ready when trac is back up.

@tor-bot tor-bot merged commit b4aa080 into torproject:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants