-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket26155 #10
Ticket26155 #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor wording changes, and then we're done.
bandwidth-file-spec.txt
Outdated
generator and use the oldest value. This ensures all the generators | ||
continue running. | ||
|
||
If there are scanners that do not run continuously, they SHOULD be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use "threads"
bandwidth-file-spec.txt
Outdated
The Unix Epoch time in seconds when the file was created. | ||
It does not follow the KeyValue format for backwards | ||
compatibility with version 1.0.0. | ||
The Unix Epoch time in seconds of the most recent generator result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change "generator result" to "generator bandwidth result".
Otherwise it's a bit confusing.
bandwidth-file-spec.txt
Outdated
[Zero or one time.] | ||
|
||
The date and time timestamp in ISO 8601 format and UTC time zone | ||
of the most recent generator result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"generator bandwidth result" for consistency
bandwidth-file-spec.txt
Outdated
compatibility with version 1.0.0. | ||
The Unix Epoch time in seconds of the most recent generator result. | ||
|
||
If there are multiple generators which can fail independently, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing "scanners" with "generators" makes this paragraph more confusing.
Please use something like "threads or subprocesses".
bandwidth-file-spec.txt
Outdated
|
||
If there are multiple generators which can fail independently, | ||
implementations SHOULD take the most recent timestamp from each | ||
generator and use the oldest value. This ensures all the generators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok to just use "thread" here.
Please add file created and latest bandwidth to the header of the example file in Appendix 2. |
Thanks for the comments, 3 last commits should solve what is commented here and in trac.tpo |
bandwidth-file-spec.txt
Outdated
@@ -128,6 +128,9 @@ It consists of: | |||
If there are scanners that do not run continuously, they SHOULD be | |||
excluded from the timestamp calculation. | |||
|
|||
If a generator does not have information about the most recent result, | |||
it MUST NOT generate the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense. And it is incomplete.
If there is no recent result, the generator MUST delete the old file, and it MUST NOT generate a new file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After our discussion on trac, this is complete, but it does not make sense.
If there are no recent results, the generator MUST NOT generate a new file.
bandwidth-file-spec.txt
Outdated
|
||
If there are scanners that do not run continuously, they SHOULD be | ||
If there are generators that do not run continuously, they SHOULD be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Threads, not generators
Looks good to me. |
It is not the timestamp when the file was created.
to make text more clar. Also: * result by bandwidth result * forgotten scanner word by generator
and change other example dates to be more coherent.
No description provided.