Add install_requires, use it in tests #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahflee
approved these changes
Jun 21, 2021
| - name: Install system dependencies | ||
| run: sudo apt-get install gettext python3 libgpgme-dev | ||
| - name: Install python dependencies | ||
| run: sudo pip3 install . |
There was a problem hiding this comment.
Note that pip install actually then obsoletes the following lines where you run setup.py build && setup.py install. Running it again is essentially harmless though.
There was a problem hiding this comment.
(You do need to specifically use pip at some point because it's the thing that verifies and installs-if-needed, the dependencies.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got some feedback from @eli-schwartz on #583 and addressed them in this PR:
setup.pytorbrowser-launcher -h