Fix "signature verification error" due to expired key #526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PGP key servers are the worst.
This error was happening because the public key included in torbrowser-launcher expired, and refreshing keys from the keys.openpgp.org keyserver failed because Tor Project didn't specifically push the new key and verify their email address with that keyserver. And refreshing from SKS keyservers is not an option because the SKS project is permanently broken, and the Tor Browser signing key is spammed with so many fake sigs that you can't download it. (The same thing has happened to my personal key.)
So this PR does away with keyservers altogether and instead updates the PGP key using WKD, fetching the public key from torproject.org, which is what Tor's sig verification documentation now calls for anyway.
It also includes a new, non-expired version of the public key. And fixes another bug, using package version comparison instead of string comparison to compare version numbers, so that "10" is not less than "9".
I'm terribly sorry for ignoring this issue for so long, everyone. If you're trustworthy and want to take over maintenance of this project please contact me at micah@micahflee.com.
Fixes #525, #524, #523, #520, #519, #518, #517, #516, #515, #514, #512, #510, #509, #508, #504, #498, #497, #496, #495, #493, #492, #491, #490, #489, #487, #481, #476, #474, #467, #458, #457, #455, #454, #453, #452, #448, #447, #437, #431, #430, #429, #428, #424, #410, #388, #386, #384, #379