Make torbrowser-launcher.mo ordering reproducible #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ordering of os.walk() is file system dependent. To make sure that the generated torbrowser-launcher.mo is reproducible bit for bit no matter on which file system it was originally generated, sort the files before feeding them to msgfmt.
diabonas
force-pushed
the
reproducible-mo-file
branch
from
228f0e0
to
da84f31
Compare
micahflee
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering of
os.walk()is file system dependent. To make sure that the generatedtorbrowser-launcher.mois reproducible bit for bit no matter on which file system it was originally generated, sort the files before feeding them tomsgfmt.