AppArmor: drop plugin container profile and allow audio #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise restarting after updating Tor Browser is broken.
…ates' "updater" file. Otherwise restarting after updating Tor Browser is broken.
Otherwise restarting after updating Tor Browser is broken.
Before Firefox 60, Web Content processes were instances of a dedicated binary (plugin-container). But since Firefox 60, the Web Content processes are instances of the very same executable as the parent Firefox process, which makes it impossible to apply a different AppArmor policy to: - Web Content processes, that should ideally be more strictly confined - the new parent Firefox process that's spawned while restarting during a self-upgrade of Tor Browser And indeed, we had to drop this distinction with commit 678d083. As a result, the new parent Firefox process that's spawned while restarting during a self-upgrade of Tor Browser runs under the torbrowser_plugin_container profile, i.e. more strictly confined than it should be, which breaks all kinds of things. A Firefox release manager tells me there's no plan to give Web Content processes a dedicated binary again; let's give up and go back to confining the entire browser under one single AppArmor profile, and rely on Firefox' own sandboxing systems to protect itself against rogue Web Content processes.
It's 2019. Users want to watch videos in Tor Browser. Having to edit files and run commands as root is not a realistic expectation for Tor Browser users.
This was referenced Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.