Split print calls on newlines #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If torbrowser-launcher cannot write to stdout, e.g. because it was started in the background and the controlling terminal has been closed or because it was started from a desktop environment launcher whose stdout has been closed, it crashes after updating the GnuPG key. This is due to print() crashing the program if stdout isn't writeable and the string to print contains a newline. To work around the problem, split the strings containing newlines into several calls to print(). See also the upstream bug at https://bugs.python.org/issue32345 Closes torproject#298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
torbrowser-launchercannot write tostdout, e.g. because it was started in the background and the controlling terminal has been closed or because it was started from a desktop environment launcher whose stdout has been closed, it crashes after updating the GnuPG key.This is due to
print()crashing the program ifstdoutisn't writeable and the string to print contains a newline.To work around the problem, split the strings containing newlines into several calls to
print().See also the upstream bug at https://bugs.python.org/issue32345
Closes #298