Apparmor: adjust profile for Tor Browser 7.0.1, support multiprocess Firefox, and various small maintenance changes #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Tor Browser 7.0.1: * /dev/dri/: we block access to the DRI nodes, so listing them would be useless * net/route: seems risky as it can leak information about IPs used on the LAN; Tor Browser seems to works perfectly without such access, so let's not grant it to be on the safe side * CPU maximum frequency:only used to optimize VP8/VP9 encoding * CPU cache size: seems unused
This is consistent with how we handle similar files so far.
abstractions/base allows access to /proc/meminfo already, so this doesn't leak much more information. I can't be sure by looking at the code, but I would not be surprised if Firefox needed more info about available memory to manage it pool of content rendering processes, when e10s is enabled.
This was referenced Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, I'm doing a first update & cleanup so I have a good starting point to work on sandboxing Tor Browser's content renderer processes more strictly: with this branch, we confine these processes in exactly the same way as the parent Firefox process. I'm pretty sure they could be confined much more strictly, without impacting UX whatsoever. And while we're at it, maybe some permissions we currently grant to the parent Firefox process are not needed anymore, as it does less work.