Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use print_function from __future__ #249

Merged
merged 1 commit into from
Jan 28, 2018

Conversation

sedrubal
Copy link
Contributor

@sedrubal sedrubal commented Nov 9, 2016

To get compatible to python3

See #214

To get compatible to python3

See torproject#214
@micahflee
Copy link
Collaborator

Sorry about ignoring this for so long. It looks like this alone doesn't bring full python3 compatibility. When I merge it (after resolving the conflicts), the imports are still using the python2 syntax:

$ python3 torbrowser-launcher
Traceback (most recent call last):
  File "torbrowser-launcher", line 29, in <module>
    import torbrowser_launcher
  File "/home/user/code/torbrowser-launcher/torbrowser_launcher/__init__.py", line 33, in <module>
    from common import Common, SHARE
ModuleNotFoundError: No module named 'common'

For now, I'm going to merge #244 to explicitly use python2, but I'd welcome a PR that migrates the whole project to python3, completely dropping python2 compatibility.

@micahflee micahflee closed this Jan 27, 2018
@micahflee
Copy link
Collaborator

Hah, you already fixed that in #251 I just realized, oops

@micahflee micahflee reopened this Jan 27, 2018
@micahflee micahflee merged commit bace7de into torproject:master Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants