Rework app armor profiles (#92) #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f includes the base, fonts, X, freedesktop.org and user-tmp abstractions.
Going to fix that in upstream AppArmor abstractions.
…rmor release yet.
On a vaguely modern GNU/Linux distribution, PulseAudio is used to play sound on the desktop. Given the TBB sets $HOME to its own directory, it doesn't find the current user's existing instance of PulseAudio, and then tries to start its own. Likely we don't want this to be allowed, in the context of these AppArmor profiles: * it's a pain to safely allow Firefox to run its own instance of PulseAudio; * even if we managed to do it, it's not obvious to me that two concurrent isntances of PulseAudio, running as the same user, but now aware of the other, would work fine together in any useful way. This can be revisited at a later point, but requires quite more work.
…f AppArmor yet. One needs the upcoming AppArmor 2.9 userspace (or some Ubuntu's über-patched snapshot of its development tree) to have this rule parse at all. And then, to make it actually useful, one also needs to run a Linux kernel with patches that have not been submitted to mainline yet. In practice, with this change applied: * Ubuntu users will need to un-comment this line, otherwise Firefox may disfunction. * Basically all other users will be happy to see this profile actually loaded, and to see their TBB's Firefox be actually confined with AppArmor. Once AppArmor 2.9 is available to most GNU/Linux users, this commit shall be reverted.
It's apparently run in an environment (LD_*, I guess) that makes it load shared libraries from the Tor directory too.
|
This is amazing, @intrigeri thank you so much. Reviewing now. |
intrigeri
pushed a commit
to intrigeri/torbrowser-launcher
that referenced
this pull request
Jul 11, 2015
commit 6552a2e Author: intrigeri <intrigeri@boum.org> Date: Wed Jul 23 18:48:40 2014 +0000 Submitted as torproject#111 These updated profiles clean up and refactor many parts of the profiles, fix a bunch of bugs, and make it fit for non-Ubuntu distros. Tested on Debian Wheezy only, as torbrowser-launcher is broken with the version of Twisted that's in Debian unstable currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updated profiles clean up and refactor many parts of the profiles, fix a bunch of bugs, and make it fit for non-Ubuntu distros. Tested on Debian Wheezy only, as torbrowser-launcher is broken with the version of Twisted that's in Debian unstable currently.