Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use calc_element() instead of theme subsetting #365

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

teunbrand
Copy link
Contributor

Hi Thomas,

This PR adresses an issue we talked about off-github.
To briefly recap, for the next release that is still far off, {ggplot2} intends to use calculated elements for various theme spacings/margins.
{patchwork} currently subsets several of these elements directly from the theme, sometimes resulting in invalid input for downstream grid/gtable functions.
The fix would be to use calc_element() to ensure any calculated properties are passed on correctly, instead of subsetting the theme.

@teunbrand
Copy link
Contributor Author

Some failing visual tests appear unrelated to this PR.
Maybe they became slightly out of date somewhere after ggplot2 3.5.0?
In any case, these are not human visible changes in the snapshots.

@thomasp85 thomasp85 merged commit 55d054f into thomasp85:main Jul 8, 2024
2 of 12 checks passed
@thomasp85
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants