Use calc_element()
instead of theme subsetting
#365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
This PR adresses an issue we talked about off-github.
To briefly recap, for the next release that is still far off, {ggplot2} intends to use calculated elements for various theme spacings/margins.
{patchwork} currently subsets several of these elements directly from the theme, sometimes resulting in invalid input for downstream grid/gtable functions.
The fix would be to use
calc_element()
to ensure any calculated properties are passed on correctly, instead of subsetting the theme.