Rework add_guides for arbitrary guide positions
#339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomasp85 This is a kind reminder that it would be swell to merge this in before ggplot2 3.5.0 is released. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates patchwork to deal with tidyverse/ggplot2#5488.
Briefly, if tidyverse/ggplot2#5488 gets merged, guides will always have 5 positions in the gtable for left, right, top, bottom and inside positions. This eliminates the need for {patchwork} to work in missing rows/columns of the gtable. Collecting guides from a gtable on the other hand, requires grabbing the guides from 5 guide-boxes instead of 1.
Some visual tests changed at the svg level due to some slight rounding changes, but for humans they look exactly the same. This isn't a consequence of this PR, but of changes in the dev version of ggplot2. Hence, I didn't include those snapshot changes.