Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adding test case for TS-5130 #26457

Merged
merged 7 commits into from
Jul 21, 2024
Merged

test: adding test case for TS-5130 #26457

merged 7 commits into from
Jul 21, 2024

Conversation

zhipzhang
Copy link

No description provided.

@tomchon
Copy link
Contributor

tomchon commented Jul 8, 2024

建议使用封装好的tdsql代替 connect的方法，用 common.py 包中的tdCom.newTdSql函数新建tdsql @zhipzhang
@tomchon
Copy link
Contributor

tomchon commented Jul 8, 2024 

    tdLog.success("%s successfully executed" % __file__)

这里会匹配这俩关键词，所以用例会失败
@tomchon
Copy link
Contributor

tomchon commented Jul 8, 2024

tdlog.exit 可以代替tdLog.debug(f"{file} Failed!")
exit(-1)
tomchon
tomchon reviewed Jul 15, 2024
View reviewed changes
tests/pytest/util/common.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

databse 单词写错了。第二个是database='None' ，是指字符串 none，不是python 的空值 None
@DuanKuanJun DuanKuanJun merged commit cfb24bc into 3.0 Jul 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@zhipzhang @tomchon @DuanKuanJun