fix:[TD-30915]tmq exit elegantly #26454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapan1121
reviewed
Jul 10, 2024
| @@ -1083,6 +1092,18 @@ static void tmqMgmtInit(void) { | |||
| } | |||
| } | |||
|
|
|||
| void tmqMgmtClose(void) { | |||
| if (tmqMgmt.timer) { | |||
| taosTmrCleanUp(tmqMgmt.timer); | |||
There was a problem hiding this comment.
大概看了一下这个函数，感觉cleanup并不能保证timer不会被回调掉，如果是这样那是不是还是不能保证不会crash？如果是这样，还不如不清空appInst，除非能找到稳定可靠的退出机制
…d heap use after free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.