Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose enterprise_id to userland handlers. #111

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Expose enterprise_id to userland handlers. #111

merged 2 commits into from
Oct 7, 2022

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Oct 3, 2022

Relies on the work in slackapi/deno-slack-runtime#38.

Exposes an enterprise_id property to all handlers.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #111 (20e964e) into main (cf32498) will not change coverage.
The diff coverage is n/a.

❗ Current head 20e964e differs from pull request most recent head e12860f. Consider uploading reports for the commit e12860f to get more accurate results

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files          46       46           
  Lines        1753     1753           
  Branches       93       93           
=======================================
  Hits         1726     1726           
  Misses         25       25           
  Partials        2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@selfcontained selfcontained left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa nice, it's just tests, types, and the test helper.

@filmaj
Copy link
Contributor Author

filmaj commented Oct 4, 2022

Ya, the runtime does the harder work of parsing through payloads, understanding when different fields exist in what payload, etc. That separation is kinda nice, as we can focus on exposing nicely documented and structured types for devs in this repo only.

@filmaj filmaj requested a review from a team as a code owner October 6, 2022 16:09
@filmaj filmaj merged commit 2f99357 into main Oct 7, 2022
@filmaj filmaj deleted the enterprise-id branch October 7, 2022 20:36
@filmaj
Copy link
Contributor Author

filmaj commented Oct 7, 2022

The runtime changes are now in production, merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants