Use <parameters>true</parameters> instead of <compilerArgs><arg>-parameters</arg></compilerArgs>

[turing85]

Since https://issues.apache.org/jira/browse/MCOMPILER-413 has been fixed with maven maven-compiler-plugin version 3.9.0, we no longer need this workaround.

[quarkus-bot]

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

• description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

_{This message is automatically generated by a bot.}

[manofthepeace]

I think quarkus is still built with 3.8.6, see here

quarkus/independent-projects/parent/pom.xml

Line 76 in cc4ab0e

<maven.min.version>3.8.6</maven.min.version>

It is in the process of being bumped here; but getting some issues. #41648

[gastaldi]

I'm confused: Is 3.9.0 the Maven Core or the Maven Compiler plugin version? If it's the later, we're in 3.13.0 already

[manofthepeace]

Right... I got confused. This should be the compiler plugin version. Please ignore my previous message.

[gsmet]

I triggered another CI run as the failures in Maven Tests - JDK 17 are a bit odd.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ef216fe.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

[turing85]

I triggered another CI run as the failures in Maven Tests - JDK 17 are a bit odd.

Seems like Maven Tests - JDK 17 succeeded this time 🙂

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ef216fe.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 devtools/cli

✖ io.quarkus.cli.plugin.PluginCatalogServiceTest.shouldSyncWhenProjectFileIsNewerThanCatalog - History

• expected: <true> but was: <false> - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.plugin.PluginCatalogServiceTest.shouldSyncWhenProjectFileIsNewerThanCatalog(PluginCatalogServiceTest.java:109)

---

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

✖ com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History

• Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

[gsmet]

Thanks, very nice cleanup!

[github-actions]

🙈 The PR is closed and the preview is expired.