Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve way to write class resources with try-with-resource #41738

Merged

Conversation

renanmachad
Copy link
Contributor

Based in this discussion here i open this PR to improve a small piece of code 👍🏻

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 7, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)
  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/core label Jul 7, 2024
@renanmachad renanmachad changed the title :art Improve way to write class resources with try-with-resource… Jul 7, 2024
@geoand geoand requested a review from mkouba July 8, 2024 14:01
@@ -124,7 +124,7 @@ public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment

@Override
public Iterable<? extends Completion> getCompletions(Element element, AnnotationMirror annotation, ExecutableElement member,
String userText) {
String userText) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like the formatter plugin was used, or?

Copy link
Contributor Author

@renanmachad renanmachad Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i think i make a mistake using CTRL + ALT + L on Intelij.
i can revert this?

@mkouba
Copy link
Contributor

mkouba commented Jul 8, 2024

Out of curiosity, what does the :Art prefix in the PR description mean?

I guess that @geoand read it as Arc and therefore requested a review from me... 😄

@geoand
Copy link
Contributor

geoand commented Jul 8, 2024

Pretty much :)

@renanmachad
Copy link
Contributor Author

Out of curiosity, what does the :Art prefix in the PR description mean?

I guess that @geoand read it as Arc and therefore requested a review from me... 😄

I'm used to it making commits with some prefixes, like :fix , :bug, but i forgot that i making a PR on Quarkus and not on my work

@mkouba
Copy link
Contributor

mkouba commented Jul 9, 2024

Out of curiosity, what does the :Art prefix in the PR description mean?
I guess that @geoand read it as Arc and therefore requested a review from me... 😄

I'm used to it making commits with some prefixes, like :fix , :bug, but i forgot that i making a PR on Quarkus and not on my work

I see. And what exactly does :Art mean?

@renanmachad
Copy link
Contributor Author

Out of curiosity, what does the :Art prefix in the PR description mean?
I guess that @geoand read it as Arc and therefore requested a review from me... 😄

I'm used to it making commits with some prefixes, like :fix , :bug, but i forgot that i making a PR on Quarkus and not on my work

I see. And what exactly does :Art mean?

Refactor of some piece of code to improve him, like more clear, more beautiful.
reference

@renanmachad
Copy link
Contributor Author

Out of curiosity, what does the :Art prefix in the PR description mean?
I guess that @geoand read it as Arc and therefore requested a review from me... 😄

I'm used to it making commits with some prefixes, like :fix , :bug, but i forgot that i making a PR on Quarkus and not on my work

I see. And what exactly does :Art mean?

Refactor of some piece of code to improve him, like more clear, more beautiful. reference

@mkouba is something wrong? You laugh make me insecure about if i make a mistake or is okay

@mkouba
Copy link
Contributor

mkouba commented Jul 9, 2024

Out of curiosity, what does the :Art prefix in the PR description mean?
I guess that @geoand read it as Arc and therefore requested a review from me... 😄

I'm used to it making commits with some prefixes, like :fix , :bug, but i forgot that i making a PR on Quarkus and not on my work

I see. And what exactly does :Art mean?

Refactor of some piece of code to improve him, like more clear, more beautiful. reference

@mkouba is something wrong? You laugh make me insecure about if i make a mistake or is okay

@renanmachad Nonono, it's fine. I'm not used to these gitmojis and the fact that :art: means Improve structure / format of the code. made me laugh...

@gsmet gsmet changed the title :Art Improve way to write class resources with try-with-resource Jul 11, 2024
@gsmet gsmet force-pushed the improve-extension-annotation-processor branch from 2b09140 to 7f9b56d Compare July 11, 2024 13:07
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7f9b56d.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Native Tests - HTTP Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ Native Tests - HTTP #

- Failing: integration-tests/vertx-graphql 

📦 integration-tests/vertx-graphql

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-vertx-graphql: Failed to build quarkus application


Flaky tests - Develocity

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

  • Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:50)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

  • Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:50)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)
@gsmet gsmet merged commit 9752b21 into quarkusio:main Jul 16, 2024
51 of 52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 16, 2024
@gsmet
Copy link
Member

gsmet commented Jul 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment