Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORM/Panache: rely on ORM getResultCount #41620

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ORM/Panache: rely on ORM getResultCount #41620

wants to merge 1 commit into from

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Jul 2, 2024

This allows us to not care about which parameters are set on the count query, since order by parameters are ignored by ORM. Which is not the case if we write our own count query.

Note that this is not yet available in HR, so we have to keep the count query logic around until that's available.

Fixes #40962

This requires ORM 6.5.3 for https://hibernate.atlassian.net/browse/HHH-18234
Also requires HR supporting getResultCount hibernate/hibernate-reactive#1932

Supercedes #41019
@FroMage
ORM/Panache: rely on ORM getResultCount
941cc29 
This allows us to not care about which parameters are set on the count
query, since `order by` parameters are ignored by ORM. Which is not
the case if we write our own count query.

Note that this is not yet available in HR, so we have to keep the count
query logic around until that's available.

Fixes quarkusio#40962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/panache
1 participant
@FroMage